Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] 🌱 Add ownerReference resilience test #2354

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[release-1.8] 🌱 Add ownerReference resilience test #2354

merged 1 commit into from
Sep 14, 2023

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon [email protected]

(cherry picked from commit d63e2bc)

Cherry-pick of #2209

@killianmuldoon
Add ownerReference resilience test
c4e60c1 
Signed-off-by: killianmuldoon <[email protected]>

(cherry picked from commit d63e2bc)
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2023
killianmuldoon
killianmuldoon commented Sep 14, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-conformance-release-1-8
  • /test pull-cluster-api-provider-vsphere-e2e-full-release-1-8
  • /test pull-cluster-api-provider-vsphere-e2e-release-1-8
  • /test pull-cluster-api-provider-vsphere-test-integration-release-1-8
  • /test pull-cluster-api-provider-vsphere-test-release-1-8
  • /test pull-cluster-api-provider-vsphere-verify-release-1-8

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-release-1-8
  • pull-cluster-api-provider-vsphere-e2e-release-1-8
  • pull-cluster-api-provider-vsphere-test-integration-release-1-8
  • pull-cluster-api-provider-vsphere-test-release-1-8
  • pull-cluster-api-provider-vsphere-verify-release-1-8

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 14, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-provider-vsphere-e2e-full-release-1-8

/hold
for CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@killianmuldoon
Copy link
Contributor Author

/retitle [release-1.8] 🌱 Add ownerReference resilience test

@k8s-ci-robot k8s-ci-robot changed the title Add ownerReference resilience test [release-1.8] 🌱 Add ownerReference resilience test Sep 14, 2023
@chrischdi
Copy link
Member

/lgtm

pending ci

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44815baab813a01db15229b8001ca18a7e03adf9

@sbueringer
Copy link
Member

Thx!

/approve

CI will block automatically. I really prefer our CAPV settings over what we have in core CAPI (manual triggered blocking jobs)

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@killianmuldoon
Copy link
Contributor Author

I really prefer our CAPV settings over what we have in core CAPI (manual triggered blocking jobs)

I'll make that change if you want - seems better than the /hold /unhold dance.

@sbueringer
Copy link
Member

sbueringer commented Sep 14, 2023 •
edited
Loading

I really prefer our CAPV settings over what we have in core CAPI (manual triggered blocking jobs)

I'll make that change if you want - seems better than the /hold /unhold dance.

+1. I don't have a good overview but should be roughly every manually triggered job should be also mandatory for merge

@k8s-ci-robot k8s-ci-robot merged commit 35b3289 into kubernetes-sigs:release-1.8 Sep 14, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxRink MaxRink Awaiting requested review from MaxRink

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @k8s-ci-robot @chrischdi @sbueringer